Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Add a lib to label/delabel events as cloudevents extensions #700

Merged
merged 6 commits into from
Mar 25, 2020

Conversation

yolocs
Copy link
Member

@yolocs yolocs commented Mar 24, 2020

Fixes #667

Proposed Changes

  • Also added broker name to the config proto. We need it for proper routing.

Release Note

Add a lib to label/delabel events as cloudevents extensions

Docs

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yolocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Mar 24, 2020
pkg/broker/eventutil/label.go Outdated Show resolved Hide resolved
pkg/broker/eventutil/label.go Outdated Show resolved Hide resolved
@yolocs yolocs requested a review from Harwayne March 24, 2020 22:08
Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/broker/eventutil/label.go Do not exist 100.0%

Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yolocs
Copy link
Member Author

yolocs commented Mar 25, 2020

/test pull-google-knative-gcp-integration-tests

@yolocs
Copy link
Member Author

yolocs commented Mar 25, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 45d9dbd into google:master Mar 25, 2020
@yolocs yolocs deleted the f/bfanout branch March 25, 2020 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Determine pubsub encoding format for decoupling topic
5 participants